Conversation
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: '1.10' | ||
| version: '1' |
There was a problem hiding this comment.
locking it to a precise minor version seems good.
Because it stops doctests breaking if julia decides to change the string representation of things again
| version: '1' | |
| version: '1.10' |
There was a problem hiding this comment.
1.10 doesn't support path, IIRC at least 1.11 is needed.
| *.jl.*.cov | ||
| *.jl.mem | ||
| /Manifest.toml | ||
| Manifest.toml |
There was a problem hiding this comment.
keeping the docs manifest around is useful to avoid breaking doctests if packages we use change their string represetations
There was a problem hiding this comment.
IMO such doctest failures should be avoided by using doctest filters or changing to more stable tests, since string representations may change even in non-breaking releases.
Co-authored-by: Frames White <me@oxinabox.net>
| *.jl.*.cov | ||
| *.jl.mem | ||
| /Manifest.toml | ||
| Manifest.toml |
There was a problem hiding this comment.
IMO such doctest failures should be avoided by using doctest filters or changing to more stable tests, since string representations may change even in non-breaking releases.
2 participants
A bit of housekeeping: This PR fixes broken and outdated badges and updates CI (eg testing of
mininstead of hardcoded1.0; removing hardcoded architectures which are not appropriate for Apple silicon; adding an SSH key to CompatHelper; usingjulia-actions/cacheinstead of manually configuredactions/cache).