Remove unsuppoted versions of DataStructures#109
Closed
andreasnoack wants to merge 1 commit intomainfrom
Closed
Conversation
The package doesn't load with these versions on Julia 1.0 which is the earliest supported version.
Member
|
We could test this with https://github.com/julia-actions/julia-downgrade-compat I assume. |
Member
|
@andreasnoack, would you please justify this PR by either
Notably, if DataStructures at one of these versions is incompatible with Julia 1.0, that should be marked elsewhere (i.e. make a PR to adjust its Julia compat bounds in the registry). The role of |
Collaborator
Author
|
Your interpretation makes it impossible to verify that this package supports these versions. It is kind of an abstract compatibility declaration, but I'll rest my case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package doesn't load with these versions on Julia 1.0 which is the earliest supported version.
I tested locally with 0.11 and tests passed.