Open
Conversation
BIP-CTV: fix mistypes, omissions, etc
This are just minor changes, which do not impact the overall logic. I hope this is not too much at once.
fresheneesz
reviewed
Dec 22, 2019
| The set of data committed to is a superset of data which can impact the TXID of the transaction, | ||
| other than the inputs. This ensures that for a given known input, the TXIDs can also be known ahead | ||
| of time. Otherwise, CHECKTEMPLATEVERIFY would not be usable for Channel Factory type constructions | ||
| as the redemption TXID could be malleated and pre-signed transactions invalidated. |
There was a problem hiding this comment.
I think malleated might have a specific meaning here (that probably should be elaborated on for clarity). So changing that word to "change" might not be the right thing here.
Author
There was a problem hiding this comment.
I assume that it is trying to refer to »transaction malleability« but it's the first time I've ever seen »malleated« and it just feels like change conveys the same meaning but is clearer.
There was a problem hiding this comment.
I assume so as well. I have seen other people use the word malleated as well in cases like this. You can see its commonality with a google search.
fresheneesz
reviewed
Dec 22, 2019
|
|
||
| =====Committing to the Sequences Hash===== | ||
|
|
||
| If we don't commit to the sequences, then the TXID can be malleated. This also allows us to enforce |
There was a problem hiding this comment.
Same here - I would keep the word "malleated" here.
JeremyRubin
force-pushed
the
ctv
branch
3 times, most recently
from
4cf129f to
80b4ba6
Compare
JeremyRubin
pushed a commit
that referenced
this pull request
Oct 15, 2021
added test vector #5 for invalid extended keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This are just minor changes, which do not impact the overall logic. I hope this is not too much at once.