Fix issue with the RfFitterDriver crashing if the RF pulse is absent.#1165
Open
Fix issue with the RfFitterDriver crashing if the RF pulse is absent.#1165
Conversation
Collaborator
Author
|
Note I also remove two comments that were left in ThreeBodySkimmer.java and FEESkimmer.java. |
baltzell
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code should not crash if the RF pulse is not detected. We have some early runs in 2021 where the RF pulse was not plugged in, so the data is garbage. We should still be able to analyze such data without needing to change the steering file.
The fix is simple, make a common sense guard against buffer over run (if you access i+1 do not loop to size()), and test if a peak was actually found before using the results.