Draft
Conversation
This reverts commit cb56c8f.
8e197ef to
f5e70e3
Compare
Collaborator
Author
|
Weird, this google json library wasn't in the jclara jar: |
Member
Perhaps then we can get rid of the dependency conflict resolution here too: Lines 227 to 235 in 1ccf10a |
Collaborator
Author
|
no luck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a
jclara-4.3.jarin this repo, which gets installed via COATJAVA's build script intocoatjava/lib/utils. That "rogue" jar serves (only) as a runtime dependency for the components of COATJAVA that extend CLARA, when run from outside CLARA, e.g.recon-util. Meanwhile, a normal CLARA installation also includes its ownjclarajar, which CLARA runtime uses while explicitly ignoringcoatjava/lib/utils. COATJAVA's maven build also ignores this rogue jar.This pull request takes a small step in cleaning this up by:
coatjava/lib/utilsAlso, as a prerequisite, a non-SNAPSHOT 4.3 maven repo was manually created on clasweb (by copying 4.3-SNAPSHOT).
coatjava/lib/utils/jclara-4.3.jaris identical in filesize andjar tfoutput.