Skip to content

Fix zensical preview in site hierarchy#2401

Merged
aOelschlager merged 2 commits intomainfrom
fix/snippets
Apr 10, 2026
Merged

Fix zensical preview in site hierarchy#2401
aOelschlager merged 2 commits intomainfrom
fix/snippets

Conversation

@joecorall
Copy link
Copy Markdown
Member

@joecorall joecorall commented Apr 9, 2026

One doc page used Reference-style links. e.g [API][api-link]

I searched our codebase for this old pattern's use with

$ rg --pcre2 -n '\[([^\]]+)\]\[\1\]' ./docs
./docs/installation/docker/site-template/site-template.md
5:The [ISLE Site Template][ISLE Site Template] is a system for installing
6:Islandora on Docker. As with ISLE-DC, it uses [Docker Compose][Docker Compose]
15:    * Click the green "Use this template" button on the [ISLE Site Template][ISLE Site Template]
18:      [Islandora Starter Site][Islandora Starter Site].

So only ./docs/installation/docker/site-template/site-template.md was doing this it seems.

But this unearthered a bug in our snippets/preview logic with the glossary that showed itself when using previews in markdown files deeper in the site hierarchy. The hook added should fix it going forward for any new pages. Here's the fixed page: https://islandora.github.io/documentation/pr-preview/pr-2401/installation/docker/site-template/site-template/

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-10 14:30 UTC

@joecorall joecorall force-pushed the fix/snippets branch 2 times, most recently from 7d11f04 to bb8a374 Compare April 9, 2026 22:28
@joecorall joecorall marked this pull request as draft April 9, 2026 22:31
@joecorall joecorall force-pushed the fix/snippets branch 4 times, most recently from cdc4a32 to ff9f690 Compare April 9, 2026 23:01
Comment thread Dockerfile Outdated
@joecorall joecorall marked this pull request as ready for review April 10, 2026 02:49
@joecorall joecorall changed the title Fix old snippets formatting Fix zensical preview in site hierarchy Apr 10, 2026
Copy link
Copy Markdown
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the links that were not working. Thanks Joe!

@aOelschlager aOelschlager merged commit aa4e8dc into main Apr 10, 2026
1 check passed
@aOelschlager aOelschlager deleted the fix/snippets branch April 10, 2026 14:29
@aOelschlager aOelschlager mentioned this pull request Apr 10, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants