fix: update metrics crate and remove unused import for rustc 1.94 compat#429
Open
mrmodolo wants to merge 1 commit intoInlyne-Project:mainfrom
Open
fix: update metrics crate and remove unused import for rustc 1.94 compat#429mrmodolo wants to merge 1 commit intoInlyne-Project:mainfrom
mrmodolo wants to merge 1 commit intoInlyne-Project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a build failure with rustc 1.94+ and removes an unused import warning.
Changes
metricsfrom 0.24.1 to 0.24.3 to fixE0521(borrowed data escapes outside of associated function) caused by a recent compiler change that rejects raw pointer casts extending lifetimes on trait objects. See Tracking Issue for breaking raw pointer casts of trait objects rust-lang/rust#141402commandimport fromclap(flagged as warning)Reproduction
Building with
rustc 1.94.0fails with:error[E0521]: borrowed data escapes outside of associated function
--> metrics-0.24.0/src/recorder/mod.rs:156:13
Fixed by running:
bash
cargo update -p metrics
cargo fix --bin "inlyne" -p inlyne --allow-dirty