Fix type mismatch in ecs_lookup_symbol on ARM/Android platforms#286
Merged
Indra-db merged 2 commits intoIndra-db:mainfrom Mar 31, 2026
Merged
Fix type mismatch in ecs_lookup_symbol on ARM/Android platforms#286Indra-db merged 2 commits intoIndra-db:mainfrom
Indra-db merged 2 commits intoIndra-db:mainfrom
Conversation
Indra-db
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ARM platforms (such as Android or ARM Linux), c_char is typically defined as u8. The current implementation of World::import hardcodes a cast to *const i8 when calling sys::ecs_lookup_symbol:
let m = unsafe { sys::ecs_lookup_symbol(raw_world, symbol.as_ptr() as *const i8, true, false) };This causes a compilation error because sys::ecs_lookup_symbol (generated by bindgen) expects *const c_char, which resolves to *const u8 on these platforms.
Changing the cast to as *const _ allows the compiler to infer the correct pointer type (*const i8 or *const u8) based on the platform-specific definition of c_char, making the code cross-platform compatible.