SystemBuilder: better handling of system creation with non-default kind while deferred#207
Open
Georgiy-Tugai wants to merge 1 commit intoIndra-db:mainfrom
Open
SystemBuilder: better handling of system creation with non-default kind while deferred#207Georgiy-Tugai wants to merge 1 commit intoIndra-db:mainfrom
Georgiy-Tugai wants to merge 1 commit intoIndra-db:mainfrom
Conversation
…nd while deferred kind_id() checks for existing phases and removes them, but the addition of the default OnUpdate phase has not been processed yet by that point (if deferred). Special case for existing entities being passed in, because they effectively have the same issue; the system builder cannot reliably know whether a kind is going to be set on the existing entity in the next defer flush.
Georgiy-Tugai
force-pushed
the
deferred-system-kind
branch
from
b0109d7 to
db52552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kind_idchecks for existing phases and removes them, but the addition of the defaultOnUpdatephase has not been processed yet by that point (if deferred).Special case for existing entities being passed in, because they effectively have the same issue; the system builder cannot reliably know whether a kind is going to be set on the existing entity in the next defer flush.