IECoreScene CurvesPrimitiveEvaluator : fix vTangent() error#1470
Conversation
|
@ivanimanishi, do you have any concerns about this fix from the IE point of view? It's one of those ones that which is a bugfix but affects the output in a way you might consider to be a breaking change if you'd already adapted to getting the wrong result. |
|
It's difficult to be sure it won't cause issues, but I'm willing to try it out and deal with compatibility issues if necessary later. |
|
I've been through the Gaffer codebase and don't see anything that will be impacted by this fix, so from our point of view we're happy to go ahead in a patch version as well. Paul will update Cinesite's internal code to account for the change when it gets released. We need to get a release containing #1471 out sharpish, so the plan is to hold back on merging this PR until that is done and then include this in the following release. |
|
@proberts-cinesite, we need to merge this to RB-10.5 rather than main - could you rebase and update the PR please? If you had time to add test coverage in |
bdd5b73 to
bdc2c93
Compare
`IECoreScene.CurvesPrimitiveEvaluator.Result.vTangent()` now returns vector pointing in the correct (opposite) direction for curves with `Linear` interpolation.
bdc2c93 to
ff2a9dc
Compare
Since we never received this rebase, and are planning a new Cortex major version for Gaffer 1.6, I've merged to main. |
Generally describe what this PR will do, and why it is needed.
IECoreScene.CurvesPrimitiveEvaluator.Result.vTangent() now returns vector pointing in the correct (opposite) direction for curves with
Linearinterpolation.Breaking Changes
changes (fixes) bevaviour of function.
Checklist