Draft
Conversation
aaadelmann
requested review from
aaadelmann and
s-mayani
and removed request for
s-mayani
aaadelmann
requested changes
Mar 15, 2026
Member
|
And b.t.w the PR is still work in progress so I can not approve. I suggest that you change to Draft, I can approve and you can merge! |
aaadelmann
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the call to evaluate_EB() happens after timeShift(), A_n has already been overwritten to be identical to A_np1, so dAdt will always be 0. This is fixed by instead using A_n and A_nm1.