Added "rename" action on dms files, only zope admins can edit id#111
Open
chris-adam wants to merge 1 commit intomasterfrom
Open
Added "rename" action on dms files, only zope admins can edit id#111chris-adam wants to merge 1 commit intomasterfrom
chris-adam wants to merge 1 commit intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a "rename" action for DMS files, exposes an Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant ActionPanel as ActionPanel<br/>(View)
participant Template as Rename Form<br/>(TAL)
participant Utils as UtilsMethods<br/>(BrowserView)
participant Storage as DMS Item<br/>(Backend)
User->>ActionPanel: Request object actions / click "rename"
ActionPanel->>ActionPanel: Check ACCEPTABLE_ACTIONS contains "rename"
ActionPanel->>Template: Render folder_rename_form
Template->>Utils: is_zope_admin()
Utils-->>Template: return admin status
Template->>User: Display form (editable id if admin, gated fields otherwise)
User->>Template: Submit rename form
Template->>Storage: Validate and perform rename
Storage-->>Template: success / failure
Template->>User: Redirect or show errors
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
cbc535e to
fbeb8d1
Compare
fbeb8d1 to
e6918b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit