ULTRA l1b small bug in stat cull#3002
Open
lacoak21 wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
Open
ULTRA l1b small bug in stat cull#3002lacoak21 wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the ULTRA L1B statistical outlier culling logic in flag_statistical_outliers() to change when an energy bin is deemed to have “too little data” to continue the Poisson-based iterative outlier detection.
Changes:
- Updated the Step 1 “insufficient bins” check from counting nonzero-count bins to checking the number of currently-unmasked spin bins (
len(counts) < 3).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
I was reviewing Bobs goodtime algorithm code to check if he updated any constants when I noticed my code had a small bug.