Intl improvement: Locale, getCanonicalLocales, supportedLocalesOf#1096
Merged
rbri merged 4 commits intoHtmlUnit:masterfrom Mar 12, 2026
Merged
Intl improvement: Locale, getCanonicalLocales, supportedLocalesOf#1096rbri merged 4 commits intoHtmlUnit:masterfrom
rbri merged 4 commits intoHtmlUnit:masterfrom
Conversation
|
Member
|
@duonglaiquang this looks great, looking forward to the things you like to do on top of this. |
Member
|
@duonglaiquang looks like my latest cleanup has borken something, working on that |
Member
|
@duonglaiquang have fixed the toString stuff and switched to array-like support. this is a bit closer to the spec. Maybe you like to backport that to your branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR does the following
Refactor Intl initialization — Move logic from
JavaScriptEngineintoIntl.init(), making the Intl module self-contained and enabling static function registration (forgetCanonicalLocales()in the later commit)Implement
Intl.LocaleImplement
Intl.getCanonicalLocales()Add
supportedLocalesOf()toIntl.NumberFormatandIntl.DateTimeFormat