This repository was archived by the owner on May 22, 2020. It is now read-only.
RUN-5679 BrowserView => View#358
Closed
pbaize wants to merge 5 commits intoHadoukenIO:developfrom
Closed
Conversation
|
9 tasks
Contributor
|
build fail |
Collaborator
Author
|
Successful build here: HadoukenIO/core#982 |
|
|
MichaelMCoates
approved these changes
Oct 16, 2019
Contributor
MichaelMCoates
left a comment
MichaelMCoates
left a comment
There was a problem hiding this comment.
LGTM. Do we have to worry about merge ordering here?
|
Collaborator
Author
|
Wrong link in the PR |
openfin-github-bot
Bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
Bot
added
auto testing done
licui3936
reviewed
Oct 17, 2019
| public GlobalHotkey: GlobalHotkey; | ||
| public BrowserView: BrowserViewModule; | ||
| public View: ViewModule; | ||
| private BrowserView: ViewModule; |
Collaborator
There was a problem hiding this comment.
why do we still need 'BrowserView'? backward compatibility?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Rename BrowserView to View. Leaves a private BrowserView to allow time to transition tests. Goes with this core pr HadoukenIO/core#982
Checklist
npm testpassesRelease Notes
Notes: