Merged
Conversation
agrossfield
reviewed
Apr 8, 2025
Member
agrossfield
left a comment
There was a problem hiding this comment.
It looks fine, but I have a very minor request:
Around lines 239 and 241, you've got if test without braces to indicate scope. It's correct as is, but please put the {} in, so someone in the future doesn't make a silly mistake.
Also, most of the changes are braces moving from the same line to the next line. I don't care one way or the other, but I thought it was weird.
Cheers,
Alan
Contributor
Author
|
I think my formatter did that. It seems to prefer: to I changed them all to the latter, and added braces to each clause. Is that OK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: lbf fixup
about: fixes subsetting in prebuilt tool
long-bond-findertitle: 'Long bond finder subset fix'
labels: 'bug-fix'
assignees: ''
Found a small but critical error in long-bond finder that makes its subsetting selection fail--it didn't call prune-bonds after subsetting.
Changes proposed in this pull request
Checklist