Open
Conversation
lukebemish
requested changes
Aug 24, 2024
Member
There was a problem hiding this comment.
Erm, not so sure on this -- @KnownImmutable is runtime retention, which means the compile-only dep there actually leaks to runtime. Does groovy have any other ways of marking this we could use? I'll poke it. You've mentioned making it a record before and that may in the end by the most sensible option, though we'll have to scour for identity equality uses and make them non-identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This offers a guarantee to the Groovy compiler that
Platformis known to be immutable and to treat it as such