Fix :Origin pivot gizmo can appear misaligned #3850
Fix :Origin pivot gizmo can appear misaligned #3850jsjgdh wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a visual bug where the origin pivot gizmo could appear misaligned within the editor. The fix ensures that the gizmo's viewport position is accurately computed by applying a transformation that correctly considers the specific layer it is associated with, thereby eliminating the misalignment. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where the origin pivot gizmo could be misaligned for nested layers. The change correctly uses downstream_transform_to_viewport to account for the full transformation hierarchy of parent layers when calculating the origin's viewport position. The previous implementation using document_to_viewport was incorrect for nested layers as it did not account for parent transforms. The fix is correct and addresses the described issue.
|
Before : 525434696-8bb9eb38-3f2a-491f-8ad4-6eefd7c11d54.mp4After : Screen.Recording.2026-03-03.at.6.15.43.PM.movI don't know if its a bug or glitch of my browser but sometimes the rotate icons got disappear as you can see in the video. |
Closes #3462