Skip to content

Fix :Origin pivot gizmo can appear misaligned #3850

Open
jsjgdh wants to merge 1 commit intoGraphiteEditor:masterfrom
jsjgdh:piviot
Open

Fix :Origin pivot gizmo can appear misaligned #3850
jsjgdh wants to merge 1 commit intoGraphiteEditor:masterfrom
jsjgdh:piviot

Conversation

@jsjgdh
Copy link
Contributor

@jsjgdh jsjgdh commented Mar 3, 2026

Closes #3462

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a visual bug where the origin pivot gizmo could appear misaligned within the editor. The fix ensures that the gizmo's viewport position is accurately computed by applying a transformation that correctly considers the specific layer it is associated with, thereby eliminating the misalignment.

Highlights

  • Origin Pivot Gizmo Alignment: Corrected the calculation of the viewport origin for the origin pivot gizmo by utilizing a layer-specific downstream transformation, resolving a potential misalignment issue.
Changelog
  • editor/src/messages/tool/common_functionality/graph_modification_utils.rs
    • Updated the get_viewport_origin function to use downstream_transform_to_viewport(layer) instead of document_to_viewport for more accurate coordinate transformation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jsjgdh jsjgdh marked this pull request as ready for review March 3, 2026 08:08
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug where the origin pivot gizmo could be misaligned for nested layers. The change correctly uses downstream_transform_to_viewport to account for the full transformation hierarchy of parent layers when calculating the origin's viewport position. The previous implementation using document_to_viewport was incorrect for nested layers as it did not account for parent transforms. The fix is correct and addresses the described issue.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@Annonnymmousss
Copy link
Contributor

Before :

525434696-8bb9eb38-3f2a-491f-8ad4-6eefd7c11d54.mp4

After :

Screen.Recording.2026-03-03.at.6.15.43.PM.mov

I don't know if its a bug or glitch of my browser but sometimes the rotate icons got disappear as you can see in the video.
If its a bug kindly check it once else ignore.
Thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Origin pivot gizmo can appear misaligned

2 participants