Skip to content

chore: Migrate gsutil usage to gcloud storage#549

Open
bhandarivijay-png wants to merge 1 commit intoGoogleContainerTools:mainfrom
bhandarivijay-png:ai-gsutil-migration-8c15727c26004be2b06b9a5ea62eb4da
Open

chore: Migrate gsutil usage to gcloud storage#549
bhandarivijay-png wants to merge 1 commit intoGoogleContainerTools:mainfrom
bhandarivijay-png:ai-gsutil-migration-8c15727c26004be2b06b9a5ea62eb4da

Conversation

@bhandarivijay-png
Copy link

Automated: Migrate {target_path} from gsutil to gcloud storage

This CL is part of the on going effort to migrate from the legacy gsutil tool to the new and improved gcloud storage command-line interface.
gcloud storage is the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with other gcloud components. 🚀

Automation Details

This change was generated automatically by an agent that targets users of gsutil.
The transformations applied are based on the gsutil to gcloud storage migration guide.

⚠️ Action Required: Please Review and Test Carefully

While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between gsutil and gcloud storage that could impact your workflows.
For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the gcloud storage rsync command has a different file deletion logic than gsutil rsync, which could lead to unintended file deletions.

Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.

Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.

Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.

Support and Collaboration

The GCS CLI team is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.
We are happy to work with you to test and adjust these changes as needed.

Contact: gcs-cli-hyd@google.com

We appreciate your partnership in this important migration effort!

#gsutil-migration

@bhandarivijay-png
Copy link
Author

Hi @thesayyn, Can we get your review on this PR? Thanks!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's Google Cloud Storage interactions by systematically replacing gsutil commands with their gcloud storage equivalents across various build and deployment scripts. The change aims to leverage the benefits of gcloud storage, such as improved performance and unified authentication, while ensuring consistency with other gcloud components. Reviewers are advised to thoroughly test the changes to confirm expected behavior.

Highlights

  • Migration to gcloud storage: All instances of gsutil commands for copying files to Google Cloud Storage have been migrated to use gcloud storage commands, aligning with Google's recommended modern tool for GCS interactions.
  • Cloud Build Integration: Cloud Build steps in deploy/cloudbuild.yaml and deploy/release_cloudbuild.yaml have been updated to utilize the gcr.io/cloud-builders/gcloud image and its storage cp --recursive command for GCS operations.
  • Automated Change: This change was automatically generated as part of an ongoing effort to transition from legacy gsutil to gcloud storage, emphasizing the need for careful review and testing due to potential behavioral differences.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Makefile
    • Updated the release target to use gcloud storage cp instead of gsutil cp for copying build artifacts to the release bucket.
  • deploy/cloudbuild.yaml
    • Switched the GCS upload step from using the gcr.io/cloud-builders/gsutil builder to gcr.io/cloud-builders/gcloud.
    • Modified the cp command arguments to storage cp --recursive to align with gcloud storage syntax.
  • deploy/release.sh
    • Replaced the gsutil cp command with gcloud storage cp for copying the container-structure-test binary to the latest directory.
  • deploy/release_cloudbuild.yaml
    • Updated the first GCS upload step to use gcr.io/cloud-builders/gcloud and gcloud storage cp --recursive for uploading build artifacts.
    • Updated the second GCS upload step to use gcr.io/cloud-builders/gcloud and gcloud storage cp --recursive for copying artifacts to the latest directory.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant