feat: shared gallery preview in AttachmentPreviewList#3044
Merged
MartinCupela merged 2 commits intomasterfrom Mar 24, 2026
Merged
feat: shared gallery preview in AttachmentPreviewList#3044MartinCupela merged 2 commits intomasterfrom
MartinCupela merged 2 commits intomasterfrom
Conversation
|
Size Change: +460 B (+0.1%) Total Size: 442 kB
ℹ️ View Unchanged
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3044 +/- ##
==========================================
+ Coverage 80.31% 80.46% +0.14%
==========================================
Files 561 561
Lines 13098 13120 +22
Branches 3413 3419 +6
==========================================
+ Hits 10520 10557 +37
+ Misses 1912 1903 -9
+ Partials 666 660 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes REACT-910
Closes REACT-911
🎯 Goal
Bug fix: GlobalModal close order (GlobalModal.tsx)
dialog from closing.
Feature: shared gallery preview in AttachmentPreviewList
toBaseImageDescriptors. Each image/video preview receives an openPreview callback that sets the initial slide index and opens the modal. Uses local showPreview state with
open/onClose props on Modal.
prop; delegates gallery opening entirely to parent.
Gallery improvements (Gallery.tsx)
Docs: ComponentContext.tsx
Other