Skip to content

fix: run-info breaks on some go:embed directives#354

Merged
wilsonjord merged 1 commit intomainfrom
fix-reorder-smoke-test-steps
Mar 18, 2026
Merged

fix: run-info breaks on some go:embed directives#354
wilsonjord merged 1 commit intomainfrom
fix-reorder-smoke-test-steps

Conversation

@wilsonjord
Copy link
Contributor

Reorder steps so setup become before run-info (which uses go list). This is so setup may build any assets used by go:embed, and allow run-info/go list to be run without issue.

Reorder steps so `setup` become before `run-info` (which uses `go list`).
This is so `setup` may build any assets used by `go:embed`, and allow
`run-info/go list` to be run without issue.
@wilsonjord
Copy link
Contributor Author

Here is a log snippet:

2026-03-18T02:02:34.5454708Z shell: /usr/bin/bash -e {0}
2026-03-18T02:02:34.5454980Z ##[endgroup]
2026-03-18T02:02:40.5316435Z ##[error]internal/ui/ui.go:5:12: pattern dist: no matching files found
2026-03-18T02:02:40.5386176Z ##[group]Run eval 'npm ci --prefix ./internal/ui
2026-03-18T02:02:40.5386567Z �[36;1meval 'npm ci --prefix ./internal/ui�[0m
2026-03-18T02:02:40.5386861Z �[36;1mnpm run build --prefix ./internal/ui�[0m
2026-03-18T02:02:40.5387115Z �[36;1m'�[0m
2026-03-18T02:02:40.5438369Z shell: /usr/bin/bash -e {0}
2026-03-18T02:02:40.5438608Z ##[endgroup]
2026-03-18T02:02:43.1886362Z 
2026-03-18T02:02:43.1887012Z added 23 packages, and audited 24 packages in 2s
2026-03-18T02:02:43.1887472Z 
2026-03-18T02:02:43.1899917Z 11 packages are looking for funding
2026-03-18T02:02:43.1900760Z   run `npm fund` for details
2026-03-18T02:02:43.1901282Z 
2026-03-18T02:02:43.1901583Z found 0 vulnerabilities
2026-03-18T02:02:43.3231998Z 
2026-03-18T02:02:43.3234049Z > build
2026-03-18T02:02:43.3235209Z > vite build

Notice the "pattern disk: no matching files found" message before the setup building step.
https://github.com/GeoNet/nema-mar-portal/actions/runs/23225582604/job/67507475123?pr=1

@wilsonjord wilsonjord requested a review from CallumNZ March 18, 2026 02:59
@wilsonjord
Copy link
Contributor Author

The simple reordering of the steps should be non-breaking - at least, I can't think of a scenario where any setup must be run after run-info...(most setup jobs are of the form sudo apt install)

Copy link
Contributor

@CallumNZ CallumNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wilsonjord wilsonjord merged commit 732480e into main Mar 18, 2026
16 checks passed
@wilsonjord wilsonjord deleted the fix-reorder-smoke-test-steps branch March 18, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants