Skip to content

Cycles : Update to 5.1.0 with even sample motion blur patches#298

Open
boberfly wants to merge 1 commit intoGafferHQ:mainfrom
boberfly:cycles510Update
Open

Cycles : Update to 5.1.0 with even sample motion blur patches#298
boberfly wants to merge 1 commit intoGafferHQ:mainfrom
boberfly:cycles510Update

Conversation

@boberfly
Copy link
Copy Markdown
Contributor

I was able to upstream the type_names() from Brecht however it isn't using the tagged release but rather the release/v5.1 branch link just to note.

https://projects.blender.org/blender/cycles/src/branch/release/v5.1/

I don't use gafferDependencies anymore and haven't fully tested the build process, they did quite a bit of cmake changes so I suspect this may not build out of the box fully.

I have changes for Gaffer to go with this as well coming.

@johnhaddon
Copy link
Copy Markdown
Member

it isn't using the tagged release but rather the release/v5.1 branch link just to note

So the build might change from one day to the next if something changes on that branch? If so, we can't accept that - we need dependencies builds to be completely repeatable. Maybe you can tie it to a specific commit by SHA?

How does this branch relate to the official 5.1 release anyway? Is it where maintenance will be done for patch versions? And is a tag for a patch likely to appear before we release 1.7?

@boberfly
Copy link
Copy Markdown
Contributor Author

Hey @johnhaddon

The difference is just that type_names() patch added - I had it as a regular patch here against the tagged version, would that be preferred over the hash key representation? Agreed it could change later down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants