Add support for DOTNET Facade FFI#320
Open
TekuSP wants to merge 12 commits intoFrameworkComputer:mainfrom
Open
Add support for DOTNET Facade FFI#320TekuSP wants to merge 12 commits intoFrameworkComputer:mainfrom
TekuSP wants to merge 12 commits intoFrameworkComputer:mainfrom
Conversation
- Introduce a new crate that exposes C-compatible functions for interacting with the EC and SMBIOS. - Integrate `csbindgen` to automatically generate C# bindings during the build process. - Implement helper types and snapshot functions in `framework_lib` to facilitate structured data retrieval. - Export functionality for platform identification, battery status, and thermal/fan control.
- Add build steps for the .NET interop crate to FreeBSD, Linux, and Windows CI jobs. - Configure CI to upload compiled native libraries and generated C# bindings as build artifacts. - Update README with build instructions and technical details for the optional .NET interop functionality.
Author
|
(And yes I did use Copilot for some tasks, as I have absolutely almost zero knowledge of RUST, I have knowledge of firmwares, OS, and frameworks in .NET (Yes we had C# OS)) |
Author
|
All tests pass and library works on my laptop, there is one slight formatting change (Cause meh Lint) and one extended helper in original source code for getting some internal values. No changes made to RUST functionality (I hope), just exported a lot of stuff for C (And C#) |
Signed-off-by: TekuSP <richard.torhan@windowslive.com>
Author
|
Signed commit. |
Refactors the FFI boundary to provide more comprehensive and structured error reporting, and to consolidate function return values. - The `FrameworkStatus` struct now uses a union to provide specific error details (e.g., invalid fan index, detailed EC response codes, device error messages). - FFI functions now return dedicated `Result` structs that combine status and data, simplifying consumption from .NET. - Introduces functions to retrieve human-readable descriptions for status codes and device errors. - Updates `build.rs` to ensure `csbindgen` reruns when `src/lib.rs` changes, improving build reliability.
Author
|
Updated to latest main, after new Framework 13 Pro with new Intel CPUs. Reworked some internal structures to make more C# sense. |
…pshot Consolidates fan RPM, presence, and stalled status into a `FrameworkFanReading` struct, leveraging a new `FrameworkFanState` enum. This improves data encapsulation and provides clearer, type-safe status information for each fan within the `FrameworkThermalSnapshot`.
Modernizes the FFI interfaces by introducing type-safe enums for various states and capabilities, and by enabling dynamic length strings for textual data. - Replaces boolean flags with dedicated enums (`FrameworkFanFeaturesState`, `FrameworkPowerSourceState`, `FrameworkBatteryState`) for clearer and more robust state representation in fan capabilities and power snapshots. - Adopts `FrameworkByteBuffer` for variable-length strings in battery details (manufacturer, model, etc.) and EC flash versions, eliminating fixed-size buffer limitations. - Restructures `FrameworkPowerSnapshot` to embed a new `FrameworkBatterySnapshot`, providing a more organized and extensible data model for power and battery information.
Author
|
Final C# version to have refactored objects, where original structs did not make sense (We have battery_count, but we cannot index batteries now etc) |
Author
|
Finalized, I am using it now in https://github.com/TekuSP/framework-dotnet and I am pretty happy about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am .NET Developer and not RUST Developer, this is warning of things to come.
I needed to integrate Framework-System into .NET ecosystem, using export "c" of RUST.
I have no idea if I have done this right, but I tried my best.
I made .NET integration library of other side here: https://github.com/TekuSP/framework-dotnet
With GIT Submodule, sample output of my test console app is:
Therefore even if my solution is bad, it works. It would be silly and stupid of me to not push this idea upstream, maybe someone will do it better, maybe someone has better solution. But this is for me only way to access Framework-System from .NET.
I did in the past app for cooling fans of MSI, want to port that for my Framework, including separate fan curves and control.