Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the customization of the bubble chat by allowing the integration of a custom HTML header, providing a more branded and flexible user experience. Additionally, it includes a crucial styling correction for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
| {/* Tool role: show tool name and tool_call_id */} | ||
| <Show when={role === 'tool' && msg.name}> | ||
| <div style={{ display: 'flex', 'align-items': 'center', gap: '8px', 'margin-top': '4px' }}> | ||
| <div style={{ display: 'flex', 'align-items': 'center', gap: '8px', 'margin-top': '4px', 'flex-wrap': 'wrap' }}> |
There was a problem hiding this comment.
This was the styling fix for tools calls:
Before
After
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature allowing a custom HTML header to be added to the chat bubble. The implementation correctly uses DOMPurify to sanitize the HTML, preventing potential XSS vulnerabilities. Additionally, it includes a styling fix for the NodeDetailDialog to handle long tool call details gracefully. The changes are well-implemented, with necessary adjustments to layout and component properties to support the new header. I have one minor suggestion to improve code clarity by replacing a magic number with a named constant.
| // In bubble mode with a custom header, the modal should cover the popup including the | ||
| // chat header — some padding offset is needed. In all other cases (full page or bubble | ||
| // without a custom header) we offset by CHAT_HEADER_HEIGHT to clear the chat title bar. | ||
| const dialogPaddingTop = () => (props.dialogContainer && props.hasCustomHeader ? 50 : CHAT_HEADER_HEIGHT); |
There was a problem hiding this comment.
The value 50 is a magic number. To improve readability and maintainability, consider defining it as a constant at the top of the file, for example: const CUSTOM_HEADER_DIALOG_PADDING = 50;. This makes the intention of having a specific offset for custom headers clearer, even if its value currently matches CHAT_HEADER_HEIGHT.
1 participant
FLOWISE-381
Adds new option on bot config so we can provide a header to the bubble chat.
Also fixed a small styling issue with the NodeDetailDialog when opening a execution detail with a tools call
When dialog opened with header
