Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Improves test coverage for the soundevents crate (including tarpaulin-targeted paths) and adjusts CI scheduling for periodic runs.
Changes:
- Add unit tests covering
top_k_from_scores, builder/accessor APIs, error paths, and output validation helpers. - Add feature-gated integration-style tests using the bundled tiny model to validate classifier behavior end-to-end.
- Update the GitHub Actions
scheduletrigger to run monthly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
soundevents/src/lib.rs |
Adds a broad set of unit and feature-gated tests to exercise more code paths and improve coverage. |
.github/workflows/ci.yml |
Updates the scheduled CI cadence (cron) for periodic workflow runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - '**.txt' | ||
| workflow_dispatch: | ||
| schedule: [cron: "0 1 */30 * *"] | ||
| schedule: |
Comment on lines
+1247
to
+1251
| fn classifier_from_file_rejects_missing_file() { | ||
| match Classifier::from_file("definitely/does/not/exist.onnx") { | ||
| Err(ClassifierError::Ort(_)) => {} | ||
| _ => panic!("expected Ort error"), | ||
| } |
Comment on lines
+1255
to
+1262
| fn classifier_new_with_custom_optimization_surfaces_ort_error() { | ||
| match Classifier::new( | ||
| Options::new("definitely/does/not/exist.onnx") | ||
| .with_optimization_level(GraphOptimizationLevel::Level3), | ||
| ) { | ||
| Err(ClassifierError::Ort(_)) => {} | ||
| _ => panic!("expected Ort error"), | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.