Skip to content

Add death animation#49

Merged
Extremelyd1 merged 4 commits intoExtremelyd1:mainfrom
BobbyTheCatfish:death-animation
Apr 12, 2026
Merged

Add death animation#49
Extremelyd1 merged 4 commits intoExtremelyd1:mainfrom
BobbyTheCatfish:death-animation

Conversation

@BobbyTheCatfish
Copy link
Copy Markdown
Contributor

@BobbyTheCatfish BobbyTheCatfish commented Apr 12, 2026

Adds animations for player deaths. The hook method is a bit more complicated than i'd like, but alas. Team Cherry decided to call their HeroController.OnDeath action before setting any cState properties. I figured it made more sense as an animation effect rather than a player update, but I can change it if need be. There are likely other leftovers that need to be removed as well.

Also fixes a bug where some attack sounds lingered and replayed, seemingly replacing other sound effects. No clue what caused it, but playing the audio as a oneshot seemed to fix it.

BobbyTheCatfish and others added 4 commits April 12, 2026 00:41
- Remove unused imports
- Remove unused (commented) hooks
- Remove debug logs to info
- Simplify effect info declarations
- Add missing comments
- Simplify frost death check
- Run style formatting
Copy link
Copy Markdown
Owner

@Extremelyd1 Extremelyd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Bobby!

You mentioned the death animation making more sense as an animation rather than a separate update, but there was a good reason for it. Animation updates are not marked as reliable in networking updates, so if the packet containing the animation gets dropped, the animation doesn't play at all. This doesn't matter in most cases, but for the death animation I figured it would be nice it always played (since it is the last animation that plays before a player disappears from screen).

We'll see how this plays out in practice though. If it happens too often that the animation is dropped, we can revert back to the death animation as a dedicated update rather than in the animation system. The code is (mostly) still there.

@Extremelyd1 Extremelyd1 changed the title Death animation Add death animation Apr 12, 2026
@Extremelyd1 Extremelyd1 merged commit b22f481 into Extremelyd1:main Apr 12, 2026
3 checks passed
@BobbyTheCatfish
Copy link
Copy Markdown
Contributor Author

I did notice some problems occasionally, moreso the animation getting overridden, but your reasoning makes more sense. I just wasn't getting the packet for some reason so I decided to go the effect route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants