test(ios): Set diffThreshold to 0.002 on CommentsScreen preview#797
Draft
cameroncooke wants to merge 1 commit intomainfrom
Draft
test(ios): Set diffThreshold to 0.002 on CommentsScreen preview#797cameroncooke wants to merge 1 commit intomainfrom
cameroncooke wants to merge 1 commit intomainfrom
Conversation
Tighten the snapshot diff tolerance for the CommentsScreen preview so small rendering regressions are caught by snapshot testing instead of being swallowed by a looser default threshold. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
📲 Install BuildsiOS
|
📸 Snapshot Test2 modified, 42 unchanged
🛸 Powered by Emerge Tools |
Sentry Snapshot Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighten the snapshot diff tolerance for the
StoryScreen_PreviewinCommentsScreen.swiftby setting.diffThreshold(0.002)on the preview.The repo recently adopted SnapshotPreviews + SwiftSnapshotTesting for
uploading previews as snapshots to Sentry (#780). The library's default
diff threshold is lenient enough that small rendering regressions in
the comments screen can slip through unnoticed. 0.002 matches a tight
tolerance while still tolerating sub-pixel antialiasing noise.
This is intentionally a one-preview change so we can observe how the
tighter threshold behaves against the existing baseline before rolling
it out more broadly to other previews.