Fix TIMESTAMP_NTZ cast not stripping timezone#116
Open
rampage644 wants to merge 1 commit intomainfrom
Open
Conversation
to_timestamp_ntz had early-return paths in return_field_from_args and invoke_with_args that preserved the input timestamp type as-is, including its timezone. This caused convert_timezone(...)::TIMESTAMP_NTZ to return timestamp_tz instead of timestamp_ntz. Now both paths apply the function's timezone policy via self.timezone(), which returns None for NTZ variants. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CAST(convert_timezone(...) AS TIMESTAMP_NTZ)was returningtimestamp_tzinstead oftimestamp_ntzbecauseto_timestamp_ntzhad early-return paths that preserved the input type's timezone. Fixed bothreturn_field_from_argsandinvoke_with_argsto apply the function's timezone policy (self.timezone()) which returnsNonefor NTZ variants, correctly stripping the timezone.Test plan
convert_timezone(...)::TIMESTAMP_NTZreturns correct datetime without timezone🤖 Generated with Claude Code