WIP: diffguard-types/lib.rs: Wrap doc identifiers in backticks#614
WIP: diffguard-types/lib.rs: Wrap doc identifiers in backticks#614EffortlessSteven wants to merge 4 commits intomainfrom
Conversation
…down Work item: work-452a2701
Work item: work-d4a75f70 This ADR documents the decision to update diffguard.toml.example to demonstrate the tags and test_cases features, which already exist in the codebase but are missing from the example file. - Add tags = ["safety"] to rust.no_unwrap (consistent with built_in.json) - Add [[rule.test_cases]] blocks with positive and negative test cases - Keep additions minimal (~10 lines) per plan review recommendations
Work item: work-d4a75f70 - Add tags = ["safety"] to rust.no_unwrap (consistent with built_in.json) - Add [[rule.test_cases]] blocks with positive and negative test cases - Positive case: input with .unwrap() should_match = true - Negative case: input with .ok() should_match = false Closes #463
…eError Doc writer: add missing docstrings to public types in diffguard-diff. - ChangeKind: explain Added/Changed/Deleted semantics - DiffLine: document path, line, content, kind fields - DiffStats: document files and lines count fields - DiffParseError: document MalformedHunkHeader and Overflow variants All predicate functions already had #[must_use] and docstrings from prior implementation work (issue #498, PR #511).
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (16)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has multiple independent changes bundled together that are better split:\n\n1. Missing import (compile error): diffguard-core/src/render.rs calls escape_md() but doesn't import it from diffguard_types. Fix: add |
Closes #385
Summary
Fix clippy::doc_markdown warnings in diffguard-types/lib.rs by wrapping bare identifiers in doc comments with backticks at lines 398 and 402.
What Changed
Test Results (so far)
Clippy shows no warnings at lines 398 and 402 for doc_markdown.
Friction Encountered
Notes