fix: nix build, including macos sandbox#529
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3caac5538b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| #[test] | ||
| #[ignore = "requires socket bind permission outside sandbox"] |
There was a problem hiding this comment.
Adding an unconditional #[ignore] here disables listen_addr_preflight_fails_when_port_is_in_use for every default cargo test run, not just the Nix macOS sandbox case mentioned in the commit message. That means regressions in ensure_listen_addr_available will no longer be caught in regular Linux/macOS CI and local development where socket bind permissions exist; this should be scoped to the sandbox-specific environment instead of globally ignored.
Useful? React with 👍 / 👎.
1 participant
Fixes npm deps in nix flake causing nix build failure.
Also marks
listen_addr_preflight_fails_when_port_is_in_usetest as ignore by default, as this fails in nix darwin sandbox, requiring socket bind permission.