DataGrid: Fix the banded Columns' vertical borders (T1318812)#32802
Open
Alyar666 wants to merge 3 commits intoDevExpress:26_1from
Open
DataGrid: Fix the banded Columns' vertical borders (T1318812)#32802Alyar666 wants to merge 3 commits intoDevExpress:26_1from
Alyar666 wants to merge 3 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing/incorrect vertical borders for banded (multi-row) DataGrid header cells across themes, and adds E2E coverage to prevent visual regressions.
Changes:
- Updated Material/Generic/Fluent SCSS to render vertical borders for multi-row header cells when column lines are disabled, including RTL-specific handling.
- Reorganized band-columns E2E tests by separating functional coverage and adding a new screenshot “matrix” test for RTL/LTR × showColumnLines combinations.
- Renamed the existing visual fixture and removed the unrelated functional scenario from the visual test file.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme-scss/scss/widgets/material/gridBase/layout/cell.scss | Adjust multi-row header border rules and add RTL override to fix band header vertical borders. |
| packages/devextreme-scss/scss/widgets/generic/gridBase/layout/cell.scss | Add multi-row header border rules + RTL override for consistent band header borders. |
| packages/devextreme-scss/scss/widgets/fluent/gridBase/layout/cell.scss | Replace previous multi-row header border logic with new border rules + RTL override. |
| e2e/testcafe-devextreme/tests/dataGrid/common/bandColumns/visual.ts | Keep only visual runtime-change scenario; rename fixture; remove unrelated functional test. |
| e2e/testcafe-devextreme/tests/dataGrid/common/bandColumns/matrix.ts | Add screenshot matrix coverage for vertical borders across showColumnLines/rtlEnabled permutations. |
| e2e/testcafe-devextreme/tests/dataGrid/common/bandColumns/functional.ts | Move the columnOption/dataField functional regression test into a dedicated functional file. |
Comment on lines
+26
to
+33
| configs.forEach(( | ||
| { showColumnLines, rtlEnabled }: { showColumnLines: boolean; rtlEnabled: boolean; }, | ||
| ): void => { | ||
| test('test', async (t) => { | ||
| const { takeScreenshot, compareResults } = createScreenshotsComparer(t); | ||
| const dataGrid = new DataGrid(GRID_CONTAINER); | ||
|
|
||
| await t.expect(dataGrid.isReady()).ok(); |
There was a problem hiding this comment.
The generated tests all use the same title ('test'). This makes TestCafe output hard to interpret and can also produce ambiguous reporting when multiple tests fail. Please use a descriptive, unique test name (e.g., include the T1318812 reference and the current showColumnLines/rtlEnabled values).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.