feat: allow sorting endpoints by active findings count#14462
Open
valentijnscholten wants to merge 2 commits intoDefectDojo:bugfixfrom
Open
feat: allow sorting endpoints by active findings count#14462valentijnscholten wants to merge 2 commits intoDefectDojo:bugfixfrom
valentijnscholten wants to merge 2 commits intoDefectDojo:bugfixfrom
Conversation
Add ability to sort the endpoint list (and host list) by the number of active findings, for both the UI and API, including the V3 Locations code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
active_finding_countbefore filtering so the sort operates at the database levelactive_finding_counttoEndpointFilterHelperandApiEndpointFilterordering fields, and expose it inEndpointSerializeractive_findingsordering toURLFilter(UI) andV3EndpointCompatibleFilterSet(API compat); exposeactive_finding_countinV3EndpointCompatibleSerializer; the annotation is already provided byannotate_location_counts_and_statusandannotate_host_contentsendpoints.htmlandurl/list.htmltemplates to render the column header as a sortable link and use the annotated count directly from the querysetendpoint_extended_test.pycovering ascending and descending sort for both endpoint list and host list views; tests automatically select the correct sort field name based onDD_V3_FEATURE_LOCATIONSCloses #10540