Improve deployment orchestrator performance#1984
Merged
shangyian merged 1 commit intoDataJunction:mainfrom Apr 10, 2026
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
427cb47 to
367ef44
Compare
20114cb to
7402716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce database interaction in deployment orchestrator
bulk_validate_node_dataentirely and uses pre-validated columns (this eliminates ANTLR4 type re-parsing for branch copies)materializations, availability, and created_by
Column type caching
lru_cache(maxsize=1024)so that repeated ANTLR4 parses for the same typestring (e.g., bigint, float) are eliminated
Metrics instrumentation
Instrument some metrics for deployment
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan