Reduce time spent making db calls when building SQL by eager loading …#1567
Draft
shangyian wants to merge 3233 commits intoDataJunction:mainfrom
Draft
Reduce time spent making db calls when building SQL by eager loading …#1567shangyian wants to merge 3233 commits intoDataJunction:mainfrom
shangyian wants to merge 3233 commits intoDataJunction:mainfrom
Conversation
…on-0.0.1a84 Bump DataJunction version to 0.0.1a84
…dims-bug Fix bug with displaying required dimensions for metrics
Disable query AST population for now
In calculating the COUNT, if we use COUNT(1), we will get the COUNT of another column, which may have a differet number of non-null values than the one we're interested in
This reverts commit f190125.
…unt-bug [fix] bug in how AVG is decomposed into measures
…on-0.0.1a85 Bump DataJunction version to 0.0.1a85
Add slack invite link
… and combines them
Fix linters Fix
* Switch to single transaction deploys so that we don't need to run multiple db transactions in parallel * Fix various minor bugs: tags should be updated rather than appended to, roles should be taken into account when comparing dimension links, and when searching for source tables, we should deduplicate
…les (DataJunction#1528) * Support querying across multiple hops on the dimensions graph with roles * Fix tests * Add check for columns * Fix tests
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: GitHub Actions Bot <>
* Add better handling for deploying source nodes * Fix tests
Co-authored-by: GitHub Actions Bot <>
* Handle catching rollback failures in session manager * Fix session reuse when compiling node sql * Revert "Fix session reuse when compiling node sql" This reverts commit e877420. * Revert "Handle catching rollback failures in session manager" This reverts commit 1386dc0. * Fix compiling node queries
Co-authored-by: GitHub Actions Bot <>
* Add support deleting nodes via the DJ CLI * Add tests for cli deletions * Fix tests
Co-authored-by: GitHub Actions Bot <>
* Update postgres data directory to new postgres 18 structure * include principalkind in when creating dj user in demo setup
* Add additional cli functionality * Handle error cases, docs, full test coverage * Add support for multiple dimensions and filters
…de details edit page (DataJunction#1547) * Fix custom_metadata field bug and make some other small changes to node details page * make lint * prettier * update UI test * fix server test * Fix default for custom metadata * Fix test * Change back to is None check --------- Co-authored-by: Yian Shang <yian.shang@gmail.com>
Co-authored-by: GitHub Actions Bot <>
…nction#1550) * Switch to using the same codemirror editor for custom metadata editing * Fix
* MAX_BY and MIN_BY functions cannot be decomposed, so metric decomposition should reflect that * Fix tests * Remove unused part of query ast update after max_by decomposition
Co-authored-by: GitHub Actions Bot <>
* If a role path is provided, should stick to the role path * Enable role path dimensions in filters Manage filters and dimensions resolution correctly Fix tests * Fix tests * Add test for storing cubes that have dimensions with role paths * Fix
…1552) * When using the DJ client to retrieve metrics data, rename all output columns from their physical names to their semantic names * Fix * Fix tests
* Fix some inconsistencies with metric display name for cubes when deployed make cube deployment part of singular commit * Remove extraneous CreateCube input map * Fix * Fix cube deployment validation * Refactor batch load of metrics and dimensions as separate functions * Make sure that we can set tags for cubes * Fix tests * Fix and cleanup tests * Fix tests
Co-authored-by: GitHub Actions Bot <>
Update YAML docs given new deployment setup
Co-authored-by: GitHub Actions Bot <>
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
…Junction#1568) * Improve namespace creation UX with inline folder-like interface * Fix tests * Fix lint
shangyian
force-pushed
the
sql-gen-eager-load
branch
from
ecde7a7 to
f7dbeec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…once
Summary
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan