Skip to content

BDMS-626: mp height fixes#615

Merged
ksmuczynski merged 4 commits intokas-well-BDMS-626-inventory-ingestion-updates_v2from
jab-bdms-626-mp-height
Mar 23, 2026
Merged

BDMS-626: mp height fixes#615
ksmuczynski merged 4 commits intokas-well-BDMS-626-inventory-ingestion-updates_v2from
jab-bdms-626-mp-height

Conversation

@jacob-a-brown
Copy link
Contributor

Why

This PR addresses the following problem / context:

  • measuring_point_height for both the MeasurementPointHistory and Observation tables should be set to the same value for well inventory
  • null mp heights should be allowed

How

Implementation summary - the following was changed / added / removed:

  • remove the requirement for mp heights
  • add test to ensure null values are allowed

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the well inventory CSV import flow to allow measuring_point_height to be omitted (NULL), including when a non-null depth_to_water_ft (observation value) is provided, while keeping the “universal MP height” behavior consistent across well (MeasuringPointHistory/Thing property) and Observation.

Changes:

  • Removed the import-time validation that rejected rows where depth_to_water_ft was present but both MP height fields were blank.
  • Updated/added a test to confirm blank MP heights are accepted when depth_to_water_ft is provided, and removed the now-obsolete failure test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
services/well_inventory_csv.py Drops the “MP height required when depth-to-water present” guard to allow NULL MP heights during import.
tests/test_well_inventory.py Reworks tests to assert NULL MP heights are permitted with non-null observations and removes the prior error expectation.

Copy link
Contributor

@ksmuczynski ksmuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ksmuczynski ksmuczynski merged commit eb6792c into kas-well-BDMS-626-inventory-ingestion-updates_v2 Mar 23, 2026
5 checks passed
@ksmuczynski ksmuczynski deleted the jab-bdms-626-mp-height branch March 23, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants