BDMS-626: mp height fixes#615
Merged
ksmuczynski merged 4 commits intokas-well-BDMS-626-inventory-ingestion-updates_v2from Mar 23, 2026
Merged
BDMS-626: mp height fixes#615ksmuczynski merged 4 commits intokas-well-BDMS-626-inventory-ingestion-updates_v2from
ksmuczynski merged 4 commits intokas-well-BDMS-626-inventory-ingestion-updates_v2from
Conversation
…jab-bdms-626-mp-height
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the well inventory CSV import flow to allow measuring_point_height to be omitted (NULL), including when a non-null depth_to_water_ft (observation value) is provided, while keeping the “universal MP height” behavior consistent across well (MeasuringPointHistory/Thing property) and Observation.
Changes:
- Removed the import-time validation that rejected rows where
depth_to_water_ftwas present but both MP height fields were blank. - Updated/added a test to confirm blank MP heights are accepted when
depth_to_water_ftis provided, and removed the now-obsolete failure test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
services/well_inventory_csv.py |
Drops the “MP height required when depth-to-water present” guard to allow NULL MP heights during import. |
tests/test_well_inventory.py |
Reworks tests to assert NULL MP heights are permitted with non-null observations and removes the prior error expectation. |
eb6792c
into
kas-well-BDMS-626-inventory-ingestion-updates_v2
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
measuring_point_heightfor both theMeasurementPointHistoryandObservationtables should be set to the same value for well inventoryHow
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?