Draft
Conversation
Contributor
|
|
nccatoni
force-pushed
the
nccatoni/dd-sts-migration
branch
5 times, most recently
from
7935ce3 to
b3a6f0c
Compare
ikraemer-dd
reviewed
Apr 3, 2026
.github/workflows/ci.yml
Outdated
| secrets: inherit | ||
| permissions: | ||
| contents: read | ||
| id-token: write |
There was a problem hiding this comment.
The permission block is not needed here: id-token: write is specified line 74, and contents: read should be defined in the policy
.github/workflows/run-exotics.yml
Outdated
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: |
There was a problem hiding this comment.
it will also need a permission block with id-token: write since this workflow calls DataDog/dd-sts-action
.github/workflows/run-end-to-end.yml
Outdated
| with: | ||
| repository: 'DataDog/system-tests' | ||
| ref: ${{ steps.compute_ref.outputs.ref }} | ||
| - name: Get Datadog credentials |
There was a problem hiding this comment.
will need id-token: write permissions to invoke DataDog/dd-sts-action
| default: "datadoghq.com" | ||
| required: false | ||
| type: string | ||
| dd_sts_policy: |
There was a problem hiding this comment.
will need id-token: write permissions to invoke DataDog/dd-sts-action
nccatoni
force-pushed
the
nccatoni/dd-sts-migration
branch
6 times, most recently
from
7a4fc9b to
107bbb0
Compare
nccatoni
force-pushed
the
nccatoni/dd-sts-migration
branch
from
107bbb0 to
b4b5967
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present