Upgrade symbolic fork with merged upstream/master (12.17.0) by jhssilva · Pull Request #6 · DataDog/symbolic

jhssilva · 2025-11-25T11:25:38Z

What?

This PR updates the Datadog symbolic fork by merging the latest changes from
getsentry/symbolic master into our dd_master branch.

How?

Key updates:

Upstream version bumped to 12.17.0 and synced to dd_master as 12.17.0-dd
All Cargo.toml conflicts resolved (kept Datadog-specific patches & features)
Regenerated Cargo.lock through cargo update
Updated symbolic workspace to track the merged upstream changes

Notes

Sentry `js-source-scopes` it's incompatible with cws_core 8.1.1 (due to using a old version of cws)

Currently the sentry js-source-scopes it's incompatible with cws_core Sentry PR#30

Options discussed

Remove the js-source-scopes ; symbolic-sourcemapcache from symbolic-cabi from the project as we aren't levering.
Point the js-source-scopes to master branch with the fix, while there isn't a new release.

Test `[fails](container::tests::test_parse_invalid_input)`

Python tests

Python test weren't executed.

Next steps:

After merging this PR, dd-source can be updated to point to this new dd_master
branch for the symbolic dependency.

Jira

RUM-13011

The `zip` crate was released by now with a fix for large >64k file archives. This unpins that crate, and does a `cargo update` for good measure.

This reverts commit 2425399.

Committed via https://github.com/asottile/all-repos

* feat(sourcebundle): Add callback to handle skipped files Add a callback to SourceBundleWriter that is called every time we skip adding a file to the bundle due to a ReadFailed error. Closes getsentry#863 * fix(sourcebundle): Skip all invalid sources getsentry#861 missed another spot where the ReadFailed error can cause the write function to fail; this commit fixes that. Fixes getsentry#860 * meta: Update changelog * apply suggestions from code review Co-authored-by: Jan Michael Auer <jan.auer@sentry.io> --------- Co-authored-by: Jan Michael Auer <jan.auer@sentry.io>

…" (getsentry#866) This reverts commit fa5edd1.

Sorting algorithms in std should be fast enough now. While we're at it, we're also replacing some unstable sorts with stable ones.

We have seen FDEs with an initial address of u64::MAX in user-provided DWARF files. Such FDEs will invariably fail to process because of either an address overflow error in gimli or an underflow in the length calculation in line 756. Therefore, we skip them immediately so we don't abort the processing of the entire file.

…#849)" (getsentry#870) This reverts the "feature part" of commit 7dc28dd (getsentry#849). The dep updates can stay. Unfortunately opening a debug session to check for the presence of sources is prohibitively expensive in terms of memory (going from ~450MB to ~3.7GB in a Python process that calls Object.features on an example 1.3GB file). In order to support this we'll have to find a more parsimonious way to check if a file contains sources.

This adjusts discover_sourcemap_embedded_debug_id so that it finds debug IDs at both "debug_id" and "debugId".

…#877) Using an alias causes deserialization to fail when both keys are set. Therefore we now read both fields and implement the logic explicitly.

jhssilva · 2025-12-04T18:01:50Z

/merge

dd-devflow-routing-codex · 2025-12-04T18:01:55Z

View all feedbacks in Devflow UI.

2025-12-04 18:01:55 UTC ℹ️ Start processing command /merge

2025-12-04 18:01:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in dd_master is approximately 0s (p90).

2025-12-04 20:02:14 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'dd_master' is 120 minutes.

jhssilva · 2025-12-08T08:54:32Z

/merge

dd-devflow-routing-codex · 2025-12-08T08:54:36Z

View all feedbacks in Devflow UI.

2025-12-08 08:54:36 UTC ℹ️ Start processing command /merge

2025-12-08 08:54:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in dd_master is approximately 0s (p90).

2025-12-08 10:54:54 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'dd_master' is 120 minutes.

jhssilva · 2025-12-09T07:36:24Z

/merge

dd-devflow-routing-codex · 2025-12-09T07:36:27Z

View all feedbacks in Devflow UI.

2025-12-09 07:36:27 UTC ℹ️ Start processing command /merge

2025-12-09 07:36:31 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in dd_master is approximately 0s (p90).

2025-12-09 09:36:46 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'dd_master' is 120 minutes.

getsentry-bot and others added 30 commits June 7, 2024 11:54

Merge branch 'release/12.9.2'

d914021

Fix nightly clippy lints (getsentry#847)

2291045

Support for DWARFv5 embedded source code extension (getsentry#849)

7dc28dd

Updated wasmparser dependency to 0.214.0 (getsentry#853)

9741cf8

Unpin zip and update dependencies (getsentry#855)

316fb39

The `zip` crate was released by now with a fix for large >64k file archives. This unpins that crate, and does a `cargo update` for good measure.

ci: dependency review action (getsentry#856)

2425399

release: 12.10.0

8195608

Merge branch 'release/12.10.0'

e91d0ca

Revert "ci: dependency review action (getsentry#856)" (getsentry#857)

0aa576d

This reverts commit 2425399.

docs(sourcebundle): Fix doc comment typo (getsentry#862)

7af6091

fix(sourcebundles): Skip invalid sources (getsentry#861)

b9c8405

release: 12.10.1

c39ef43

Merge branch 'release/12.10.1'

63daf8f

all-repos: update actions/upload-artifact to v4 (getsentry#858)

fa5edd1

Committed via https://github.com/asottile/all-repos

Revert "all-repos: update actions/upload-artifact to v4 (getsentry#858)…

1623dfc

…" (getsentry#866) This reverts commit fa5edd1.

release: 12.11.0

3a33dba

Merge branch 'release/12.11.0'

a384028

ref(debuginfo): Replace dmsort with std sort (getsentry#869)

7cee3f4

Sorting algorithms in std should be fast enough now. While we're at it, we're also replacing some unstable sorts with stable ones.

release: 12.11.1

9e281c0

Merge branch 'release/12.11.1'

d845f97

release: 12.12.0

19e7d46

Merge branch 'release/12.12.0'

868c283

fix: Changelog (getsentry#875)

5d4e750

feat(js): Read debug IDs from debugId field (getsentry#874)

b3d4ff9

This adjusts discover_sourcemap_embedded_debug_id so that it finds debug IDs at both "debug_id" and "debugId".

release: 12.12.1

e5d3511

Merge branch 'release/12.12.1'

e08c803

fix(js): Resolve conflict between "debugId" and "debug_id" (getsentry…

0277066

…#877) Using an alias causes deserialization to fail when both keys are set. Therefore we now read both fields and implement the logic explicitly.

dd-devflow bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: queued mergequeue-status: in_progress labels Dec 2, 2025

dd-devflow bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: rejected mergequeue-status: queued mergequeue-status: in_progress labels Dec 4, 2025

dd-devflow bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: rejected mergequeue-status: queued mergequeue-status: in_progress labels Dec 8, 2025

dd-devflow bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: rejected mergequeue-status: queued mergequeue-status: in_progress labels Dec 9, 2025

buranmert merged commit 0cd2eec into DataDog:dd_master Dec 9, 2025
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade symbolic fork with merged upstream/master (12.17.0)#6

Upgrade symbolic fork with merged upstream/master (12.17.0)#6
buranmert merged 124 commits intoDataDog:dd_masterfrom
jhssilva:dd_master

jhssilva commented Nov 25, 2025 •

edited

Loading

Uh oh!

jhssilva commented Dec 4, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 4, 2025 •

edited

Loading

Uh oh!

jhssilva commented Dec 8, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

jhssilva commented Dec 9, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

jhssilva commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

How?

Notes

Sentry js-source-scopes it's incompatible with cws_core 8.1.1 (due to using a old version of cws)

Test [fails](container::tests::test_parse_invalid_input)

Python tests

Next steps:

Jira

Uh oh!

jhssilva commented Dec 4, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhssilva commented Dec 8, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhssilva commented Dec 9, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

jhssilva commented Nov 25, 2025 •

edited

Loading

Sentry `js-source-scopes` it's incompatible with cws_core 8.1.1 (due to using a old version of cws)

Test `[fails](container::tests::test_parse_invalid_input)`

dd-devflow-routing-codex bot commented Dec 4, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Dec 8, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Dec 9, 2025 •

edited

Loading