fix(ci): skip base_service Valgrind leak and xfail OpenSSL SNI tests#3772
Open
fix(ci): skip base_service Valgrind leak and xfail OpenSSL SNI tests#3772
Conversation
…ci [7.0] The test has a memory leak under Valgrind on PHP 7.0 that causes the Makefile's leaked-test check to fail. Skip it during the Valgrind pass (USE_TRACKED_ALLOC=1) to unblock CI.
sni_server.phpt, sni_server_key_cert.phpt, and bug74796.phpt are loopback TLS tests that do not check SKIP_ONLINE_TESTS and fail when CI pod networking does not support SNI loopback connections. PHP 7.1 already had sni_server.phpt xfailed; add all three for 7.0 and 7.2+.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 732de87 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…ice leak Set DD_SPAWN_WORKER_STABLE_TRAMPOLINE=1 in the test_extension_ci Valgrind pass so the sidecar spawn_worker writes the trampoline to a stable per- process path instead of a random temp file that gets self-deleted before Valgrind can read it. Updates libdatadog to DataDog/libdatadog#1844.
…chema - runtime_stack moved to message.experimental.runtime_stack - new error block with native crash stack (Datadog Crashtracker 1.0 format) - data_schema_version bumped to 1.6 - signal message changed to "Process terminated with SI_USER (SIGSEGV)"
…T_FILES for PECL package
Benchmarks [ tracer ]Benchmark execution time: 2026-04-03 20:39:46 Comparing candidate commit 732de87 in PR branch Found 2 performance improvements and 2 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/ext/base_service.phpt: add--SKIPIF--to skip under Valgrind (USE_TRACKED_ALLOC=1). The test has a memory leak on PHP 7.0 that causestest_extension_ci: [7.0]to fail via the leaked-test check in the Makefile.dockerfiles/ci/xfail_tests/*.list(7.0, 7.2–8.5): addsni_server.phpt,sni_server_key_cert.phpt, andbug74796.phpt. These are loopback TLS tests that do not checkSKIP_ONLINE_TESTSand fail due to CI pod networking producing flakiness. PHP 7.1 already hadsni_server.phptxfailed; this extends coverage to all other versions.Test plan
test_extension_ci: [7.0]Valgrind pass no longer reports leaked testPHP Language Tests(all versions) no longer fail on OpenSSL SNI tests