ci: test system-tests agent_interface_timeout fix for flaky PHP tests#3766
ci: test system-tests agent_interface_timeout fix for flaky PHP tests#3766
Conversation
Points system-tests clone at branch with increased agent_interface_timeout for TRACING_CONFIG_NONDEFAULT (5s -> 15s) to account for PHP sidecar's 5s trace buffer + agent flush cycle. Temporary branch - DO NOT MERGE. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d016182d33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <?php dockerhub_login() ?> | ||
| - /tmp/vault kv get --format=json "kv/k8s/gitlab-runner/dd-trace-php/datadoghq-api-key" 2>/dev/null | python3 -c "import sys,json;print(json.load(sys.stdin)['data']['data']['key'])" > /tmp/.dd-api-key 2>/dev/null || true | ||
| - git clone https://github.com/DataDog/system-tests.git | ||
| - git clone --branch maxim/fix-php-config-tests-use-library-interface https://github.com/DataDog/system-tests.git |
There was a problem hiding this comment.
Revert temporary system-tests branch pin
This change makes CI clone DataDog/system-tests from maxim/fix-php-config-tests-use-library-interface instead of the default stable branch, so merged pipelines will depend on a personal feature branch rather than upstream system-tests. That means routine System Tests runs no longer validate the canonical suite and can fail immediately if the feature branch is renamed, force-pushed, or removed.
Useful? React with 👍 / 👎.
|
✨ Fix all issues with BitsAI or with Cursor
|
DO NOT MERGE - Test branch
Testing a system-tests fix for consistently failing PHP tests in
[tracer-release]:Test_Config_HttpServerErrorStatuses_FeatureFlagCustom::test_status_code_200Test_Config_HttpServerErrorStatuses_FeatureFlagCustom::test_status_code_202Test_Config_UnifiedServiceTagging_CustomService::test_specified_service_nameTest_Basic::test_main(IPv6)Root cause hypothesis
PHP's libdatadog sidecar buffers traces for up to 5s (
DEFAULT_FLUSH_INTERVAL_MS=5000) before sending to the agent. The agent then needs ~10s to flush to the backend. The default 5sagent_interface_timeoutin system-tests isn't enough for this chain.Other languages send traces directly (no sidecar), so they don't hit this timing issue.
What this tests
Points system-tests at branch
maxim/fix-php-config-tests-use-library-interfacewhich increasesagent_interface_timeoutfrom 5s to 15s forTRACING_CONFIG_NONDEFAULTandIPV6scenarios.System-tests PR: DataDog/system-tests#6670
How to validate
[tracer-release]manually from this branch