Batch endpoint collection & remove Wordpress Endpoint collection#3764
Merged
Batch endpoint collection & remove Wordpress Endpoint collection#3764
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
cataphract
approved these changes
Apr 1, 2026
Contributor
cataphract
left a comment
cataphract
left a comment
There was a problem hiding this comment.
Looks fine, I'd just add a comment explaining ddtrace_telemetry_finalize doesn't suffice. Also arginfo seems to have been generated with a different version of the script. I suppose that should be pinned
Leiyks
approved these changes
Apr 2, 2026
| RETURN_FALSE; | ||
| } | ||
|
|
||
| if (!ddtrace_sidecar || !ddtrace_sidecar_instance_id || !DDTRACE_G(sidecar_queue_id)) { |
Contributor
There was a problem hiding this comment.
Shouldn't we also add !DDTRACE_G(telemetry_buffer) in this condition as well for consistency ?
bwoebi
force-pushed
the
bob/batch-endpoint
branch
5 times, most recently
from
6b7aaa2 to
9b92ee4
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…ge on wordpress Batch ack sending too Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
The sidecar's write_shm_file() serializes buffered_integrations as HashSet<Integration>, but the PHP-side reader in components-rs deserialized it as HashSet<String>. This mismatch has existed since the SHM cache was introduced in 91222ad ("feat: reduce telemetry sent", #3316), but was latent: config_sent was set true before any integrations appeared in SHM, and integration dedup (the only other consumer) was silently broken with the sidecar deduplicating server-side as a fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/batch-endpoint
branch
from
9b92ee4 to
5cf8ebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoint collection is also called multiple times in symfony in close succession (before the sidecar actually is done processing).
This leads to quite a bit of overhead.