Skip to content

[ACTP] retrieve tracing informations from backend#49598

Open
julesmcrt wants to merge 2 commits intojules.macret/Q/rshell/telemetryfrom
jules.macret/Q/par/retrieve-span-from-backend
Open

[ACTP] retrieve tracing informations from backend#49598
julesmcrt wants to merge 2 commits intojules.macret/Q/rshell/telemetryfrom
jules.macret/Q/par/retrieve-span-from-backend

Conversation

@julesmcrt
Copy link
Copy Markdown
Contributor

@julesmcrt julesmcrt commented Apr 20, 2026

What does this PR do?

Improve #49526 by getting the trace / span IDs from the backend
This way all spans are linked in the UI of Datadog!
Also requires backend PR https://github.com/DataDog/dd-source/pull/412290

Motivation

Describe how you validated your changes

Additional Notes

@julesmcrt julesmcrt requested review from a team as code owners April 20, 2026 13:27
@julesmcrt julesmcrt requested a review from ihssane-yb April 20, 2026 13:28
@julesmcrt julesmcrt changed the base branch from main to jules.macret/Q/rshell/telemetry April 20, 2026 13:28
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Apr 20, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Apr 20, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

p.telemetry = telemetry.NewTelemetry(
&http.Client{Transport: httputils.CreateHTTPTransport(p.coreConfig)},
configutils.SanitizeAPIKey(p.coreConfig.GetString("api_key")),
cfg.DatadogSite,
observability.ParService,
)

P2 Badge Reuse the existing light-tracer flusher

When PAR is embedded in the Cluster Agent with private_action_runner.enabled and the default agent_telemetry.enabled=true, this starts a second installertelemetry.NewTelemetry alongside the Cluster Agent's agent-telemetry light tracer (cmd/cluster-agent/subcommands/start/command.go:201, comp/core/agenttelemetry/impl/agenttelemetry.go:152). Both instances drain the package-global globalTracer via extractCompletedSpans, which calls globalTracer.flushCompletedSpans() and stamps empty span services from the winning telemetry instance, so the PAR flusher can steal/mislabel agent startup spans (or the agent flusher can drain PAR spans) depending on ticker timing. Please share one telemetry owner or make the tracer/client state instance-scoped before adding this PAR flusher.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 20, 2026

Go Package Import Differences

Baseline: d0fef68
Comparison: 3bf466d

binaryosarchchange
privateactionrunnerlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/fleet/installer/telemetry
privateactionrunnerlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/fleet/installer/telemetry
privateactionrunnerwindowsamd64
+10, -0
+github.com/DataDog/datadog-agent/pkg/fleet/installer/telemetry
+github.com/go-ole/go-ole
+github.com/go-ole/go-ole/oleutil
+github.com/shirou/gopsutil/v4/common
+github.com/shirou/gopsutil/v4/cpu
+github.com/shirou/gopsutil/v4/host
+github.com/shirou/gopsutil/v4/mem
+github.com/shirou/gopsutil/v4/net
+github.com/shirou/gopsutil/v4/process
+github.com/yusufpapurcu/wmi
privateactionrunnerdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/fleet/installer/telemetry
privateactionrunnerdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/fleet/installer/telemetry

@julesmcrt julesmcrt force-pushed the jules.macret/Q/rshell/telemetry branch from e514c88 to 914e439 Compare April 20, 2026 13:51
julesmcrt and others added 2 commits April 20, 2026 15:53
Backend sends uint64 with omitempty; use same type and call
StartSpanFromUint64IDs so IDs don't round-trip through decimal strings.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 20, 2026

Files inventory check summary

File checks results against ancestor d0fef680:

Results for datadog-agent_7.80.0~devel.git.60.3bf466d.pipeline.108552928-1_amd64.deb:

No change detected

@julesmcrt julesmcrt force-pushed the jules.macret/Q/par/retrieve-span-from-backend branch from 292abd3 to 3bf466d Compare April 20, 2026 13:56
@julesmcrt julesmcrt added the backport/7.79.x Automatically create a backport PR to the 7.79.x branch once the PR is merged label Apr 20, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ff04247c-07f1-4945-94a5-8ce9d4674023

Baseline: d0fef68
Comparison: 3bf466d
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -2.05 [-5.06, +0.95] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_memory memory utilization +0.55 [+0.47, +0.63] 1 Logs
ddot_logs memory utilization +0.48 [+0.42, +0.54] 1 Logs
otlp_ingest_logs memory utilization +0.43 [+0.32, +0.54] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.38 [+0.20, +0.56] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.33 [+0.11, +0.55] 1 Logs
quality_gate_logs % cpu utilization +0.25 [-1.38, +1.89] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.24 [+0.21, +0.28] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.17 [+0.02, +0.32] 1 Logs
ddot_metrics_sum_delta memory utilization +0.05 [-0.13, +0.23] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.50, +0.58] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.10, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.15, +0.14] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.21, +0.19] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.21, +0.19] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.47, +0.40] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.04 [-0.10, +0.03] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.08 [-0.49, +0.33] 1 Logs
file_tree memory utilization -0.09 [-0.15, -0.03] 1 Logs
otlp_ingest_metrics memory utilization -0.12 [-0.27, +0.04] 1 Logs
quality_gate_idle memory utilization -0.14 [-0.19, -0.08] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.58 [-0.77, -0.39] 1 Logs
quality_gate_metrics_logs memory utilization -0.98 [-1.21, -0.75] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -2.05 [-5.06, +0.95] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 718 ≥ 26
docker_containers_memory memory_usage 10/10 276.77MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 710 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 175.74MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 497.42MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 206.78MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 353.29 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 417.77MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/7.79.x Automatically create a backport PR to the 7.79.x branch once the PR is merged internal Identify a non-fork PR short review PR is simple enough to be reviewed quickly team/action-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant