Draft
Conversation
Introduce process.sid as a first-class field on process events. Kernel side: add a sid slot to pid_cache_t and inherit it from the parent at fork time, so children initially share the parent's session. User side: expose SID in the SECL model, serializers, and marshallers so rules can reference process.sid. Raw packet event offsets are bumped by 8 bytes to accommodate the new field.
When the agent starts, it snapshots the process tree from /proc to populate its process cache. Parse the Sid field from /proc/<pid>/status so each snapshotted entry has its session ID without waiting for a setsid() hook to fire.
Hook the setsid(2) syscall on exit. After a successful call, the task is the new session leader, so its SID equals its own (host-namespace) PID by definition. Write that value straight into pid_cache[pid].sid. No kernel struct walking is required, so the hook works uniformly on every kernel without BTF- or offset-based fallbacks.
Propagate SID from the kernel event into the process resolver. When an event reports a non-zero SID, update the cached process entry so subsequent events (and rule evaluations on process.sid) observe the new value without waiting for the next exec.
Cover two scenarios:
sid-updated-after-setsid A process that called setsid is the
session leader, so process.sid == its PID.
sid-inherited-not-leader A child exec'd from a session leader
inherits the leader's SID, so process.sid
equals one of its ancestors' PIDs and
differs from its own PID.
Use SysProcAttr{Setsid: true} to create a new session from Go directly
rather than shelling out to setsid(1), which avoids a KMT-specific
failure mode where setsid -f exits non-zero.
Rules are scoped to a unique env var so unrelated sh/true invocations
in the CI pod can't trigger them.
Contributor
Files inventory check summaryFile checks results against ancestor 0f8f2684: Results for datadog-agent_7.80.0~devel.git.51.40c4d8a.pipeline.108540918-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 0f8f268 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -2.83 | [-5.75, +0.09] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.56 | [+0.50, +0.62] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.50 | [+0.33, +0.66] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.50 | [+0.26, +0.74] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.28 | [+0.23, +0.34] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.16 | [+0.13, +0.20] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | +0.13 | [+0.05, +0.21] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.10 | [-0.05, +0.25] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.05 | [+0.00, +0.11] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.05 | [-0.18, +0.27] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.47, +0.49] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.21, +0.21] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.24, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.41, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.14, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.07 | [-0.51, +0.37] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.34 | [-0.40, -0.29] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.37 | [-0.46, -0.27] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.65 | [-0.83, -0.47] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.68 | [-0.83, -0.53] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.98 | [-1.15, -0.81] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.10 | [-2.74, +0.53] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -2.83 | [-5.75, +0.09] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 706 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 278.39MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 512 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 4 = 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 176.52MiB ≤ 181MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 4 = 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 503.01MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 207.87MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 419.17 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 416.47MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Contributor
eBPF complexity changesSummary result: ✅ - stable
runtime_security detailsruntime_security [programs with changes]
runtime_security [programs without changes]
runtime_security_fentry detailsruntime_security_fentry [programs with changes]
runtime_security_fentry [programs without changes]
runtime_security_syscall_wrapper detailsruntime_security_syscall_wrapper [programs with changes]
runtime_security_syscall_wrapper [programs without changes]
This report was generated based on the complexity data for the current branch theop/debug-sid (pipeline 108540918, commit 40c4d8a) and the base branch main (commit 8e2a37e). Objects without changes are not reported. Contact #ebpf-platform if you have any questions/feedback. Table complexity legend: 🔵 - new; ⚪ - unchanged; 🟢 - reduced; 🔴 - increased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Describe how you validated your changes
Additional Notes