Skip to content

Update kube-state-metrics from v2.13 to v2.18 — Validate Static Quality Gates#49594

Draft
L3n41c wants to merge 1 commit intomainfrom
lenaic/update-kube-state-metrics-v2.18_squashed
Draft

Update kube-state-metrics from v2.13 to v2.18 — Validate Static Quality Gates#49594
L3n41c wants to merge 1 commit intomainfrom
lenaic/update-kube-state-metrics-v2.18_squashed

Conversation

@L3n41c
Copy link
Copy Markdown
Member

@L3n41c L3n41c commented Apr 20, 2026

Update the kube-state-metrics dependency from v2.13 (fork based on CONS-7514 branch) to v2.18 (fork based on lenaic/public-discovery branch).

All cherry-picked commits from the old fork (panic fixes, cronjob timezone features) are now in upstream. The only remaining fork change is moving internal/discovery/ to pkg/discovery/ so that external consumers can use customresourcestate.FromConfig().

Adapt to breaking API changes in KSM v2.18:

  • BuildStoresFunc/BuildCustomResourceStoresFunc: add limit int64 param
  • allowdenylist.IsIncluded/IsExcluded: handle new (bool, error) return
  • CRDiscoverer: add CRDsUpdateEventsCounter field (new in v2.18)
  • DefaultResources: endpoints replaced by endpointslices
  • Remove stale kube_endpoint_address_available and kube_endpoint_address_not_ready metric mapper entries (metrics removed upstream in v2.14)

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Update the kube-state-metrics dependency from v2.13 (fork based on
CONS-7514 branch) to v2.18 (fork based on lenaic/public-discovery
branch).

All cherry-picked commits from the old fork (panic fixes, cronjob
timezone features) are now in upstream. The only remaining fork change
is moving internal/discovery/ to pkg/discovery/ so that external
consumers can use customresourcestate.FromConfig().

Adapt to breaking API changes in KSM v2.18:
- BuildStoresFunc/BuildCustomResourceStoresFunc: add limit int64 param
- allowdenylist.IsIncluded/IsExcluded: handle new (bool, error) return
- CRDiscoverer: add CRDsUpdateEventsCounter field (new in v2.18)
- DefaultResources: endpoints replaced by endpointslices
- Remove stale kube_endpoint_address_available and
  kube_endpoint_address_not_ready metric mapper entries (metrics
  removed upstream in v2.14)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@L3n41c L3n41c added this to the 7.80.0 milestone Apr 20, 2026
@L3n41c L3n41c added the qa/done QA done before merge and regressions are covered by tests label Apr 20, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/network-path team/container-platform The Container Platform Team labels Apr 20, 2026
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Apr 20, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 20, 2026

Go Package Import Differences

Baseline: 695e39f
Comparison: f26c529

binaryosarchchange
agentlinuxamd64
+3, -0
+github.com/dlclark/regexp2
+github.com/dlclark/regexp2/syntax
+github.com/hashicorp/go-metrics/compat
agentlinuxarm64
+3, -0
+github.com/dlclark/regexp2
+github.com/dlclark/regexp2/syntax
+github.com/hashicorp/go-metrics/compat
agentwindowsamd64
+3, -0
+github.com/dlclark/regexp2
+github.com/dlclark/regexp2/syntax
+github.com/hashicorp/go-metrics/compat
agentdarwinamd64
+3, -0
+github.com/dlclark/regexp2
+github.com/dlclark/regexp2/syntax
+github.com/hashicorp/go-metrics/compat
agentdarwinarm64
+3, -0
+github.com/dlclark/regexp2
+github.com/dlclark/regexp2/syntax
+github.com/hashicorp/go-metrics/compat
agentaixppc64
+1, -0
+github.com/hashicorp/go-metrics/compat
heroku-agentlinuxamd64
+1, -0
+github.com/hashicorp/go-metrics/compat
cluster-agentlinuxamd64
+2, -0
+github.com/dlclark/regexp2
+github.com/dlclark/regexp2/syntax
cluster-agentlinuxarm64
+2, -0
+github.com/dlclark/regexp2
+github.com/dlclark/regexp2/syntax
otel-agentlinuxamd64
+1, -0
+github.com/hashicorp/go-metrics/compat
otel-agentlinuxarm64
+1, -0
+github.com/hashicorp/go-metrics/compat
host-profilerlinuxamd64
+1, -0
+github.com/hashicorp/go-metrics/compat
host-profilerlinuxarm64
+1, -0
+github.com/hashicorp/go-metrics/compat

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 20, 2026

Files inventory check summary

File checks results against ancestor 695e39f7:

Results for datadog-agent_7.80.0~devel.git.2.f26c529.pipeline.108533649-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ebde734c-9625-46d8-a10f-0928059db354

Baseline: 695e39f
Comparison: f26c529
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.35 [+0.33, +6.38] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.35 [+0.33, +6.38] 1 Logs
ddot_logs memory utilization +0.84 [+0.77, +0.91] 1 Logs
otlp_ingest_logs memory utilization +0.43 [+0.33, +0.54] 1 Logs
otlp_ingest_metrics memory utilization +0.43 [+0.28, +0.59] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.43 [+0.37, +0.49] 1 Logs
quality_gate_idle memory utilization +0.33 [+0.28, +0.38] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.06 [+0.03, +0.10] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.11, +0.18] 1 Logs
quality_gate_logs % cpu utilization +0.02 [-1.62, +1.66] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.20, +0.22] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.00 [-0.40, +0.41] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.11, +0.11] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.21, +0.21] 1 Logs
docker_containers_memory memory utilization -0.01 [-0.09, +0.07] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.46, +0.40] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.57, +0.49] 1 Logs
quality_gate_metrics_logs memory utilization -0.06 [-0.29, +0.17] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.20 [-0.42, +0.02] 1 Logs
file_tree memory utilization -0.22 [-0.28, -0.16] 1 Logs
ddot_metrics_sum_delta memory utilization -0.27 [-0.44, -0.09] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.48 [-0.67, -0.29] 1 Logs
ddot_metrics memory utilization -0.53 [-0.72, -0.34] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.61 [-0.77, -0.46] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 674 ≥ 26
docker_containers_memory memory_usage 10/10 276.82MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 721 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 175.60MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 498.61MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 208.94MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 344.12 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 403.96MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/system-probe internal Identify a non-fork PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team team/network-path

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant