Add 'tasks/agent.py' to global cache list

[dkirov-dd]

What does this PR do?

Motivation

We want to modify the agent.py script to take into account integrations missing a manifest.json (which is becoming the new standard).

The current script and cache are making the Agent ship without these integrations.

Describe how you validated your changes

Additional Notes

[chouquette]

Could you elaborate on what kind of changes need to invalidate the cache? This could be OK but since you also mention a manifest.json file, I'm a bit unsure what the expected behavior is

[dkirov-dd]

@chouquette The manifest.json was referring to the integration manifests in integrations-core. The agent.py task collects the integrations that are supposed to be packaged with the agent and expects this file to be present.

#49553 modifies the task so that it handles the missing manifest.json files in integrations-core properly.

Therefore I think we only need changes to the agent.py task logic to invalidate the cache.

I hope this answers the question!

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor cee04ee5:

Results for datadog-agent_7.80.0~devel.git.45.a932786.pipeline.108508152-1_amd64.deb:

No change detected

[alopezz]

I think this is an acceptable change, though it could be better if either:

• The relevant code was moved out of tasks/agent.py into something more specific to the integrations.
• The relevant code was actually part of integrations-core, such that this would be covered by the use of the integrations-core hash as part of the cache key.

Worthy of note is that some of the code in question might need to be called from Bazel pretty soon, regardless of whether it stays in python or it ends up being migrated to Starlark.

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c25b8376-3dab-4abd-b2a5-60dec7236e12

Baseline: bbd4700
Comparison: e4196f9
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-1.04	[-4.07, +2.00]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle	memory utilization	+0.63	[+0.58, +0.69]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.37	[+0.19, +0.55]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.28	[+0.06, +0.50]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.03	[-0.37, +0.43]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.03	[-0.18, +0.24]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.02	[-0.42, +0.47]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.02	[-0.11, +0.14]	1	Logs
➖	ddot_metrics	memory utilization	+0.00	[-0.18, +0.19]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.21, +0.20]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.53, +0.51]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.14, +0.08]	1	Logs
➖	file_tree	memory utilization	-0.04	[-0.10, +0.02]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.10	[-0.16, -0.04]	1	Logs
➖	ddot_logs	memory utilization	-0.22	[-0.29, -0.15]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.25	[-0.40, -0.09]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.32	[-0.35, -0.28]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	-0.34	[-0.44, -0.23]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.44	[-0.62, -0.27]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.65	[-0.80, -0.49]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.80	[-1.04, -0.57]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-1.04	[-4.07, +2.00]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.32	[-2.88, +0.25]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-1.98	[-2.15, -1.82]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	572 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	275.73MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	693 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.24GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	176.01MiB ≤ 181MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	499.22MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	210.12MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	366.86 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	404.76MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.