Skip to content

[go migration] cmd/... layer 0, partial#49567

Open
aiuto wants to merge 8 commits intomainfrom
aiuto/orph_cmd
Open

[go migration] cmd/... layer 0, partial#49567
aiuto wants to merge 8 commits intomainfrom
aiuto/orph_cmd

Conversation

@aiuto
Copy link
Copy Markdown
Contributor

@aiuto aiuto commented Apr 19, 2026

What does this PR do?

Initial bazel migration for cmd things

  • shift cmd exclusion from BUILD.bazel to cmd/BUILD.bazel
  • Add some layer 0 packages
    • cmd/cws-instrumentation/subcommands
    • cmd/secret-generic-connector/backend/... - except hashicorp, which needs human touch. dda inv tidy did not add dependencies.
  • gazelle added tests to some pre-existing BUILD files which were not being ignored now

Mostly justbazel run //:gazelle with a few target_compatible_withs added by hand

** Initial bazel migration for cmd things

- shift cmd exclusion from BUILD.bazel to cmd/BUILD.bazel
- Add some layer 0 packages
  - cmd/cws-instrumentation/subcommands
  - cmd/secret-generic-connector/backend/... - except hashicorp, which needs human touch
- gazelle added tests to some pre-existing BUILD files which were not being ignored now
@aiuto aiuto requested a review from a team as a code owner April 19, 2026 16:22
@aiuto aiuto added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Apr 19, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Apr 19, 2026
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Apr 19, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 19, 2026

Files inventory check summary

File checks results against ancestor 3a85c628:

Results for datadog-agent_7.80.0~devel.git.59.8c62c41.pipeline.108568575-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Apr 19, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fd8bb0f9-621c-4101-b7bc-0f7e986f57a3

Baseline: b62aa66
Comparison: 8c62c41
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.34 [-3.34, +2.67] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.97 [+1.78, +2.16] 1 Logs
quality_gate_logs % cpu utilization +0.75 [-0.84, +2.33] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.41 [+0.23, +0.59] 1 Logs
docker_containers_memory memory utilization +0.34 [+0.26, +0.42] 1 Logs
quality_gate_idle_all_features memory utilization +0.15 [+0.11, +0.18] 1 Logs bounds checks dashboard
file_tree memory utilization +0.11 [+0.06, +0.17] 1 Logs
quality_gate_idle memory utilization +0.03 [-0.02, +0.08] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.38, +0.41] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.19, +0.20] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.14, +0.15] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.12, +0.11] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.20, +0.19] 1 Logs
otlp_ingest_metrics memory utilization -0.01 [-0.16, +0.15] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.43, +0.41] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.55, +0.47] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.10 [-0.32, +0.11] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.13 [-0.28, +0.03] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.28 [-0.35, -0.22] 1 Logs
ddot_metrics_sum_delta memory utilization -0.33 [-0.50, -0.15] 1 Logs
docker_containers_cpu % cpu utilization -0.34 [-3.34, +2.67] 1 Logs
ddot_logs memory utilization -0.70 [-0.77, -0.63] 1 Logs
otlp_ingest_logs memory utilization -1.02 [-1.13, -0.91] 1 Logs
quality_gate_metrics_logs memory utilization -1.69 [-1.92, -1.45] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 686 ≥ 26
docker_containers_memory memory_usage 10/10 276.41MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 697 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 175.32MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 501.41MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 209.53MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 346.57 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 415.00MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@aiuto aiuto added the ask-review Ask required teams to review this PR label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed component/system-probe internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant