[Go migration] Layer 15, some 16, + orphans

[aiuto]

What does this PR do?

• Does more migrations in layer 15, layer 16 and orphans.
  • Each edit was pure Gazelle, no hand changes for tags needed.
• Adds the skill to do this, and the tool the skill runs.
  • this is the second set of changes done with this pair, so I think it is ready to share for reuse.
  • it's all claude code, but it is throwaway after the migration is done.

Added build files

• comp/core/configsync/BUILD.bazel
• comp/core/configsync/configsyncimpl/BUILD.bazel
• comp/core/tagger/impl-remote/BUILD.bazel
• comp/core/ipc/impl-none/BUILD.bazel
• comp/core/ipc/impl/BUILD.bazel
• comp/core/ipc/mock/BUILD.bazel
• comp/core/log/fx-trace/BUILD.bazel
• comp/core/log/fx/BUILD.bazel
• comp/forwarder/defaultforwarder/internal/retry/BUILD.bazel
• comp/forwarder/defaultforwarder/transaction/BUILD.bazel
• comp/forwarder/orchestrator/BUILD.bazel
• comp/forwarder/orchestrator/orchestratorinterface/BUILD.bazel
• comp/serializer/logscompression/BUILD.bazel
• comp/serializer/logscompression/def/BUILD.bazel
• comp/serializer/metricscompression/BUILD.bazel
• comp/serializer/metricscompression/def/BUILD.bazel
• pkg/discovery/model/BUILD.bazel
• pkg/fleet/daemon/BUILD.bazel
• pkg/logonduration/BUILD.bazel
• pkg/logs/client/BUILD.bazel
• pkg/logs/client/mock/BUILD.bazel
• pkg/logs/internal/util/BUILD.bazel
• pkg/logs/internal/util/opener/BUILD.bazel
• pkg/logs/service/BUILD.bazel
• pkg/networkdevice/testutils/BUILD.bazel
• pkg/persistentcache/BUILD.bazel
• pkg/runtime/BUILD.bazel
• pkg/security/metrics/BUILD.bazel
• pkg/security/seclog/BUILD.bazel
• pkg/trace/containertags/BUILD.bazel
• pkg/trace/payload/BUILD.bazel
• pkg/trace/pb/BUILD.bazel
• pkg/trace/remoteconfighandler/BUILD.bazel
• pkg/trace/telemetry/BUILD.bazel
• pkg/trace/testutil/BUILD.bazel
• pkg/trace/transform/BUILD.bazel
• pkg/util/os/BUILD.bazel
• pkg/util/sync/BUILD.bazel

Describe how you validated your changes

CI and manual testing.

Additional Notes

This was mostly AI driven.

pick the targets

• Use experimental/teams/agent-supply-chain/go_migration_module_graph/find_safe_to_migrate.py to get a ranked list of packages.
• Regenerate https://datadoghq.atlassian.net/wiki/spaces/ABLD/pages/edit-v2/6411551531. See experimental/teams/agent-supply-chain/go_migration_module_graph/README.md
• Select a good set from that. Sometimes the html list says things are ready, but the other tool says no.

let claude have a go at it

• have claude read the skill from this PR.
• pick a subset of things from the ready to migrate list
• let it rip. It created a little batch script to do them and report.
• There are a bunch it can't do. We should feed those findings back into the safe to migrate tool.

When the PR feels big enough (30-50 files?), mail it.

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 3a85c628:

Results for datadog-agent_7.80.0~devel.git.60.e8e89e6.pipeline.108569208-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8fd8bd1d-ee8d-41d8-8d77-b31b8c6c16af

Baseline: 7a96bfa
Comparison: 9d7f704
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-1.70	[-4.70, +1.30]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	ddot_logs	memory utilization	+0.56	[+0.49, +0.63]	1	Logs
➖	docker_containers_memory	memory utilization	+0.36	[+0.26, +0.45]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.26	[+0.07, +0.44]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.15	[+0.09, +0.22]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.13	[-0.10, +0.35]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.11	[+0.08, +0.14]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.04	[-0.12, +0.20]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.04	[-0.39, +0.46]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.19, +0.21]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.48, +0.50]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.20, +0.21]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.00	[-0.15, +0.16]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.11, +0.10]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.40, +0.38]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.14, +0.08]	1	Logs
➖	file_tree	memory utilization	-0.10	[-0.16, -0.05]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.13	[-0.36, +0.10]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	-0.19	[-0.37, -0.00]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.20	[-0.30, -0.11]	1	Logs
➖	quality_gate_idle	memory utilization	-0.31	[-0.37, -0.26]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.37	[-0.52, -0.21]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.45	[-2.08, +1.17]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-1.70	[-4.70, +1.30]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	709 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	277.80MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	685 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.24GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	174.46MiB ≤ 181MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	494.70MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	212.62MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	358.79 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	423.76MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4724be638e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".