fix: address file browser bonus issues#369
Draft
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Draft
fix: address file browser bonus issues#369avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
Hey @pradeeban I kept this PR intentionally narrow. Also If you prefer a different size threshold than 10MB, I can adjust it in this PR :p |
pradeeban
reviewed
Mar 22, 2026
| import { actionType as T } from '../reducer'; | ||
|
|
||
| const getGraphFun = (superState) => superState.curGraphInstance; | ||
| const MAX_FILE_SIZE = 10 * 1024 * 1024; |
Member
There was a problem hiding this comment.
Create 10 as a constant instead.
(Then you can compute 1010241024 from that variable)
Then use that constant in the message in line 111. Currently 10 is hard-coded in that error message.
Also, briefly document this in a convenient place in concore-editor.
As in....
"To change the file limit, this is what you do:"
Maybe a newly created DEV-GUIDE.md where we keep documenting similar concore-editor configuration trivia?
Member
|
@avinxshKD Pls address the above comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the bonus issues from #365 in a focused way.
Changes:
Made extension blocklist check case-insensitive (.PNG, .JPEG now blocked).
Added a file-size guard (10MB) before opening files to prevent UI freezes on huge files.
Stopped writing raw File objects to localStorage; now only serializable metadata is stored.