Merged
Conversation
Add `cone generate-alias` to automatically generate aliases for entitlements based on configurable schemas (resource-entitlement, app-entitlement, etc.) with support for custom formats, dry-run mode, and AWS permission set handling. Also adds UpdateEntitlement method to C1Client interface.
Replace the N+1 admin permission check (which listed all apps and all app users) with a direct role check on AuthIntrospect. Remove the interactive "are you an admin?" prompt — just check the roles. Remove duplicate resourceName/isGenericEntitlement computation in processEntitlement. The first pass was being overwritten by the second. Move regexp compilation to package-level vars instead of compiling per-call in cleanText. Validate --schema flag against known values instead of silently falling through to the default case. Unexport Stats and CommandFlags (only used in main package). Replace hand-rolled contains() with slices.Contains.
robert-chiniquy
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cone generate-aliasto automatically generate aliases for entitlementsresource-entitlement,app-entitlement,app-resource-entitlement,resource-type-entitlement, and custom formats--dry-run,--force,--skip-aws, and resource type filteringUpdateEntitlementmethod to C1Client interfaceUsage
Test plan
cone generate-alias --dry-runshows preview without modifyingcone generate-aliascreates aliases with default schema--schemaflag switches between schemas correctly--skip-awsexcludes AWS permission sets--forceoverrides existing aliases