Add virtual-entitlements create command#135
Merged
robert-chiniquy merged 4 commits intomainfrom Mar 30, 2026
Merged
Conversation
Add `cone virtual-entitlements create` for creating manually-managed resource types, resources, and entitlements on ConductorOne apps. Supports both CLI flags and YAML file input.
2fb9239 to
57b4765
Compare
Fix gosec false positives with nolint annotations, lowercase error strings per Go convention, and simplify embedded field selectors.
57b4765 to
467b728
Compare
ResolveResourceType was title-casing the normalized enum key, which produced incorrect display names for multi-word types (e.g. "Profile_type" instead of "Profile Type"). Use a dedicated map of canonical display names matching the C1 server conventions. Also document the slug collision behavior in makeSlug.
Resolve conflicts in main.go and client.go — keep both virtualEntitlements and generateAlias additions.
robert-chiniquy
approved these changes
Mar 30, 2026
| const durationInputTip = "We accept a sequence of decimal numbers, each with optional fraction and a unit suffix," + | ||
| "such as \"12h\", \"1w2d\" or \"2h45m\". Valid units are (m)inutes, (h)ours, (d)ays, (w)eeks." | ||
| const justificationWarningMessage = "Please provide a justification when requesting access to an entitlement." | ||
| const justificationWarningMessage = "please provide a justification when requesting access to an entitlement" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cone virtual-entitlements createcommand for creating manually-managed resource types, resources, and entitlements on ConductorOne apps--app,--resource,--type,--entitlements) and YAML file input (--from-file)CreateManuallyManagedResourceType,CreateManuallyManagedResource,CreateAppEntitlement,SearchApps,ResolveAppByNameOrIDUsage
Test plan
make build)go vet ./...passesgo test ./...passescone virtual-entitlements --helpshows subcommandcone virtual-entitlements create --helpshows all flags