Open
Conversation
Author
|
I noticed that when the extra context is being read properly, the inline comments function fails to post the comment to github due to github's api protection that inline comments can only be allowed on diff lines. The alternative to this would be to leave a regular comment on a PR like this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Python Parser solution and modified the EnclosingContext to return as a Node | SyntaxNode | null to adjust. Updated the review file to ensure the line bounds are being read from each type of context.
Includes console logs to ensure the capture of an enclosing context.
Parsing Algorithm:
Definitions: function, class
Blocks: if, while, with, block, for, try
Dynamic solution:
Example logging: